Conversation
… WAV before passing to dit-vae Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
…ry across storage, serving, and spawn Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MP3 decoding issue in COVER mode
Fix COVER mode MP3 failure: AUDIO_DIR path mismatch breaks file resolution for dit-vae
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.env.examplesetAUDIO_DIR=./public/audio, whichresolveFromRootexpands againstAPP_ROOT(project root) →<root>/public/audio. ButLocalStorageProviderhardcoded its path three levels up fromserver/src/services/storage/→<root>/server/public/audio. Files were written to one place, binary told to read from another —drmp3_open_file_and_read_pcm_frames_f32opened nothing and returnedNULL.Changes
.env.example:AUDIO_DIR=./public/audio→./server/public/audio(correct relative path fromAPP_ROOT)storage/local.ts: Replaced hardcodedpath.join(__dirname, '../../../public/audio')withconfig.storage.audioDir— storage provider now always writes where the rest of the system readsserver/src/index.ts: Express/audiostatic mount now usesconfig.storage.audioDirinstead of hardcodedpath.join(__dirname, '../public/audio')— all three consumers share one valueconfig/index.ts: Comment updated to reflect single-source-of-truth designacestep.ts: Reverted incorrectensureWavFormatFFmpeg shim —audiohacking/acestep.cpp@copilot/add-wav-mp3-conversiondecodes MP3 natively viadr_mp3.h